This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Add a first JSON macro based on package:json/json.dart. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
force-pushed
the
json-macro
branch
3 times, most recently
from
379819c to
f335ef9
Compare
davidmorgan
force-pushed
the
json-macro
branch
from
f335ef9 to
79fa863
Compare
|
Filed an issue #70 for the templating discussion, with some initial thoughts on the topic :) |
jakemac53
reviewed
Sep 13, 2024
davidmorgan
commented
Sep 26, 2024
| @@ -11,6 +11,16 @@ | |||
| "isField": true, | |||
| "isMethod": false, | |||
| "isStatic": false | |||
| }, | |||
| "returnType": { | |||
There was a problem hiding this comment.
Yes, definitely: as we discussed we probably want to end up with something flat but probably still giving basic "available properties" at each point.
Added a TODO in definitions.dart
// TODO(davidmorgan): make Member a union.
jakemac53
approved these changes
Sep 26, 2024
|
Congratulations 🙌 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a minimal JSON macro, lots of TODOs.
Adds return types for fields to the model + (analyzer only) query handling.
Skip golden tests for analyzer/CFE if there are no goldens, instead of failing.
Uses templating for identifiers as suggested in dart-lang/language#1989 (comment) ... this is just a proof of concept, we should discuss whether we want templating and if so how it fits into the overall design: it could be client side only or we make the template format part of the protocol. (In the sense of "this string has this specified format which won't change, if you want something different add a new type / field").
I didn't look too closely at the augmentation golden file, just make it approximately match the package:json/json.dart output for the same code. I realize we need yet another type of test, to compile the code with macro applications and then test with it, which in this case would test the JSON produced by the JSON macro. I'll look at how to add that...